Conversion to React Testing Library #1208

merodiro · 2020-12-04T16:27:53Z

Convert tests to React Testing Library as mentioned in #1207

Checklist

only relevant code is changed (make a diff before you submit the PR)
run tests npm run test
tests are included
documentation is changed or added

destructure the use of wrapper and ignore the return when it's not used

coveralls · 2020-12-04T16:29:17Z

Coverage increased (+0.7%) to 96.372% when pulling ff25ba1 on merodiro:rtl-migration into 3d9c042 on i18next:master.

test/trans.render.icu.spec.js

…o rtl-migration

test/withTranslation.spec.js

trans.render.spec.js: Convert to RTL. 22 tests.

…o rtl-migration

test/trans.render.object.spec.js

test/useTranslation.ready.spec.js

tigerabrodi · 2020-12-04T21:15:09Z

@adrai @jamuhl I just tried converting withSSR.spec.js to RTL, for some reason I get a TypeError, that i18n.off is not a function? Do you have any ideas what could be causing this? Thanks 💕

Test running in watch mode

adrai · 2020-12-04T21:19:27Z

probably you need to define the off function in the mockI18n object

We discussed about this and it does not seem to be necessary to have screen as a comment nor use it, since we are using toMatchInlineSnapshot for inline snapshots.

tigerabrodi · 2020-12-04T21:25:37Z

probably you need to define the off function in the mockI18n object

@adrai Works like a charm 🎉 🙌

3 tests. off method has been added to mockI18n

tigerabrodi · 2020-12-05T10:30:12Z

@adrai @jamuhl In the test/typescript folder, the name of the files have a suffix of .test, I wonder why, since I could not find anything imported from enzyme in those files.

adrai · 2020-12-05T10:36:12Z

I don't know, maybe just convention? Maybe @jamuhl knows why?

tigerabrodi · 2020-12-05T11:41:43Z

I don't know, maybe just convention? Maybe @jamuhl knows why?

@jamuhl I also found many functions in the test/typescript folder, that does not get exported nor used, I wonder if we should keep them? And of course, my question would be, what are those doing?

This would of course be a separate PR if any, sorry for bringing it up in this PR 👍.

Added packages for the Linter setting for TL & Jest-DOM | Cleanup and Refactoring

tigerabrodi · 2020-12-07T15:44:25Z

Thanks @JacobMGEvans 🥰

tigerabrodi · 2020-12-07T16:00:06Z

@JacobMGEvans @balavishnuvj @merodiro @juhanakristian I am fine with this being reviewed by the maintainers 😃.

If you guys are also fine with it, just give this a thumbs-up, otherwise, what do you think still needs to change or be updated?

4 thumbs ups and this should be review-ready I guess 💯

JacobMGEvans · 2020-12-07T16:05:36Z

@JacobMGEvans @balavishnuvj @merodiro @juhanakristian I am fine with this being reviewed by the maintainers 😃.

If you guys are also fine with it, just give this a thumbs-up, otherwise, what do you think still needs to change or be updated?

4 thumbs ups and this should be review-ready I guess 💯

Do we know why the CircleCI stuff keeps failing?

tigerabrodi · 2020-12-07T16:06:59Z

@JacobMGEvans No idea tbh, clicked on it and somehow had to login. @adrai @jamuhl Do you guys know why circleci keeps failing? All tests are passing locally 🤷‍♂️

…nBand mode

tigerabrodi · 2020-12-07T16:17:23Z

CI should not fail anymore after the last commit hopefully 😝 🤞

adrai · 2020-12-07T16:38:31Z

I don't see the circleci output eihter, but if I run the tests locally I get an error in "useTranslation.loading.spec.js"

test/useTranslation.loading.spec.js

…o rtl-migration

tigerabrodi · 2020-12-07T17:02:04Z

I don't see the circleci output eihter, but if I run the tests locally I get an error in "useTranslation.loading.spec.js"

Yeah, this has to be fixed. Currently no ideas, @marcosvega91 do you have an idea? Thanks 🙏 🥰

marcosvega91 · 2020-12-07T17:17:20Z

let me check the code :)

marcosvega91

Let me know if is not clear :)

test/useTranslation.loading.spec.js

CI/CD should pass if these assertions work Co-authored-by: Marco Moretti <[email protected]>

tigerabrodi · 2020-12-07T18:01:03Z

@adrai and @jamuhl You guys can review this now 😁 🥰

adrai · 2020-12-07T18:03:32Z

lgtm, but the boss needs to review it too 😉

package.json

jamuhl · 2020-12-09T07:37:17Z

was merged

beside that @tigerabrodi have a look at https://github.com/i18next/react-i18next#core-contributors if anyone else feels like planning to help this project in the future - would be happy to add you to the list too!

jamuhl · 2020-12-09T07:38:53Z

thanks to all helping with this change...having the tests updated to rtl is awesome 👍

tigerabrodi · 2020-12-09T18:33:53Z

@jamuhl 🥰 💞

merodiro added 3 commits December 4, 2020 04:42

add react-testing-library

56e82cb

migrate provider and icu tests to react testing library

337d863

destructure wrapper

2274b28

destructure the use of wrapper and ignore the return when it's not used

Aprillion reviewed Dec 4, 2020

View reviewed changes

test/trans.render.icu.spec.js Outdated Show resolved Hide resolved

merodiro and others added 9 commits December 4, 2020 19:52

use inline snapshots for trans.render.icu

501af2a

migrate trans.render.list to react testing library

e5e06a0

Translation.spec.js, using toMatchInlineSnapshot, 1 test suite

bb91f14

Merge branch 'rtl-migration' of github.com:merodiro/react-i18next int…

f0c7a09

…o rtl-migration

migrate trans.render.object to react testing library

3676df2

Convert useTranslation.spec.js to RTL, 6 tests

a075cca

Merge branch 'rtl-migration' of github.com:merodiro/react-i18next int…

70e5c1c

…o rtl-migration

remove empty options from render()

c913b06

withTranslation.spec.js to RTL, 3 tests

1907fb2

Aprillion reviewed Dec 4, 2020

View reviewed changes

test/withTranslation.spec.js Outdated Show resolved Hide resolved

juhanakristian and others added 3 commits December 4, 2020 22:10

Migrate useTranslation.ready.spec.js to RTL. 7 tests.

e23776c

withTranslation.spec.js: add firstChild to assertion

a28d8e0

trans.render.spec.js: Convert to RTL. 22 tests.

Merge branch 'rtl-migration' of github.com:merodiro/react-i18next int…

717c598

…o rtl-migration

juhanakristian reviewed Dec 4, 2020

View reviewed changes

test/trans.render.object.spec.js Outdated Show resolved Hide resolved

tigerabrodi reviewed Dec 4, 2020

View reviewed changes

test/useTranslation.ready.spec.js Show resolved Hide resolved

remove unused enzyme import

1ad16b5

delete unused screen and respective comments in 3 files.

e7ba58e

We discussed about this and it does not seem to be necessary to have screen as a comment nor use it, since we are using toMatchInlineSnapshot for inline snapshots.

tigerabrodi and others added 2 commits December 4, 2020 22:29

withSSR to RTL:

a752a39

3 tests. off method has been added to mockI18n

Updated snapshot in withTranslation

e7835e5

Merge pull request #2 from merodiro/feature/eslint-rtl-settings

98fe895

Added packages for the Linter setting for TL & Jest-DOM | Cleanup and Refactoring

juhanakristian and others added 2 commits December 7, 2020 18:13

Removed unused test component

0e4640a

add react-rest-renderer to prevent tests failing when running in runI…

664a354

…nBand mode

Renamed TestElements to TestComponent

15fc415

adrai reviewed Dec 7, 2020

View reviewed changes

test/useTranslation.loading.spec.js Outdated Show resolved Hide resolved

adrai reviewed Dec 7, 2020

View reviewed changes

test/useTranslation.loading.spec.js Outdated Show resolved Hide resolved

tigerabrodi added 2 commits December 7, 2020 18:00

update test titles in useTranslation.loading.spec.js

1410c4f

Merge branch 'rtl-migration' of github.com:merodiro/react-i18next int…

ced297c

…o rtl-migration

marcosvega91 suggested changes Dec 7, 2020

View reviewed changes

test/useTranslation.loading.spec.js Outdated Show resolved Hide resolved

Update test/useTranslation.loading.spec.js

0985e09

CI/CD should pass if these assertions work Co-authored-by: Marco Moretti <[email protected]>

jamuhl requested changes Dec 8, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

move react-test-renderer to dev dependencies

ed26a1c

merodiro requested a review from jamuhl December 8, 2020 10:29

Merge branch 'master' into rtl-migration

ff25ba1

jamuhl approved these changes Dec 9, 2020

View reviewed changes

jamuhl merged commit ce174ac into i18next:master Dec 9, 2020

balavishnuvj deleted the rtl-migration branch December 9, 2020 11:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conversion to React Testing Library #1208

Conversion to React Testing Library #1208

merodiro commented Dec 4, 2020

coveralls commented Dec 4, 2020 •

edited

Loading

tigerabrodi commented Dec 4, 2020 •

edited

Loading

adrai commented Dec 4, 2020

tigerabrodi commented Dec 4, 2020

tigerabrodi commented Dec 5, 2020 •

edited

Loading

adrai commented Dec 5, 2020

tigerabrodi commented Dec 5, 2020

tigerabrodi commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020 •

edited

Loading

JacobMGEvans commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020 •

edited

Loading

adrai commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020

marcosvega91 commented Dec 7, 2020

marcosvega91 left a comment

tigerabrodi commented Dec 7, 2020

adrai commented Dec 7, 2020

jamuhl commented Dec 9, 2020

jamuhl commented Dec 9, 2020

tigerabrodi commented Dec 9, 2020

Conversion to React Testing Library #1208

Conversion to React Testing Library #1208

Conversation

merodiro commented Dec 4, 2020

Checklist

coveralls commented Dec 4, 2020 • edited Loading

tigerabrodi commented Dec 4, 2020 • edited Loading

Test running in watch mode

adrai commented Dec 4, 2020

tigerabrodi commented Dec 4, 2020

tigerabrodi commented Dec 5, 2020 • edited Loading

adrai commented Dec 5, 2020

tigerabrodi commented Dec 5, 2020

tigerabrodi commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020 • edited Loading

JacobMGEvans commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020 • edited Loading

adrai commented Dec 7, 2020

tigerabrodi commented Dec 7, 2020

marcosvega91 commented Dec 7, 2020

marcosvega91 left a comment

Choose a reason for hiding this comment

tigerabrodi commented Dec 7, 2020

adrai commented Dec 7, 2020

jamuhl commented Dec 9, 2020

jamuhl commented Dec 9, 2020

tigerabrodi commented Dec 9, 2020

coveralls commented Dec 4, 2020 •

edited

Loading

tigerabrodi commented Dec 4, 2020 •

edited

Loading

tigerabrodi commented Dec 5, 2020 •

edited

Loading

tigerabrodi commented Dec 7, 2020 •

edited

Loading

tigerabrodi commented Dec 7, 2020 •

edited

Loading