Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion to React Testing Library #1207

Closed
tigerabrodi opened this issue Dec 4, 2020 · 2 comments
Closed

Conversion to React Testing Library #1207

tigerabrodi opened this issue Dec 4, 2020 · 2 comments

Comments

@tigerabrodi
Copy link
Contributor

tigerabrodi commented Dec 4, 2020 •
edited
Loading

Conversion to React Testing Library

Since I and my friends will be working on this conversion, we thought of creating an issue to track the progress. 👏

How do you prefer us to work, in separate small PRs or a few bigger ones? 🙄

Our suggestion would be to work in smaller PRs, as they are easier to review. 🙌

I was thinking personally, not more than one test for each PR? 🤔

What do you think @adrai and @jamuhl, any suggestions/questions? 😃

Also thanks for this oppoturnity 💕 🥰
@adrai
Copy link
Member

adrai commented Dec 4, 2020

Personally I like 1 big PR, with incremental commits, but at the end of the day, do it however you like to do ;-)

@merodiro merodiro mentioned this issue Dec 4, 2020
Merged
4 tasks
@tigerabrodi
Copy link
Contributor Author

Closing this issue, PR has been merged 🎉 🤘 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrai @tigerabrodi