Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional "lookupHeader" to replace default header #180

Merged
merged 2 commits into from
Apr 18, 2019
+1 −1
Merged

Add optional "lookupHeader" to replace default header #180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a759abc
add optional lookupHeader
Apr 12, 2019
e866750
rollback lookupHeader checking
Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/languageLookups/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ export default {
let headers = req.headers;
if (!headers) return found;

let lookupExist = options.lookupHeader !== undefined;
let lookupHeader = lookupExist ? headers[options.lookupHeader] : undefined;

let locales = [];
let acceptLanguage = headers['accept-language'];
let acceptLanguage = lookupHeader || headers['accept-language'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this not be just a one liner?

let acceptLanguage = options.lookupHeader ? headers[options.lookupHeader] : headers['accept-language'];

Copy link
Contributor Author

@Dominic-Preap Dominic-Preap Apr 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I thought I want to have a fallback to default if lookupHeader is provided but empty. It seems I don't have to do that.


if (acceptLanguage) {
let lngs = [], i, m;
Expand Down