Add optional "lookupHeader" to replace default header #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamuhl
requested changes
Apr 18, 2019
src/languageLookups/header.js
Outdated
| let locales = []; | ||
| let acceptLanguage = headers['accept-language']; | ||
| let acceptLanguage = lookupHeader || headers['accept-language']; |
There was a problem hiding this comment.
could this not be just a one liner?
let acceptLanguage = options.lookupHeader ? headers[options.lookupHeader] : headers['accept-language'];
There was a problem hiding this comment.
At first, I thought I want to have a fallback to default if lookupHeader is provided but empty. It seems I don't have to do that.
|
@jamuhl Done, I've just changed to one liner. |
|
published in [email protected] |
|
If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for issue #179.