chore(ci): fix breaking tests #8413
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,15 +19,23 @@ jobs: | |
| name: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Get Go Version | ||
| run: | | ||
| #!/bin/bash | ||
| GOVERSION=$({ [ -f .go-version ] && cat .go-version; }) | ||
| echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV | ||
| - name: Setup Go | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: ${{ env.GOVERSION }} | ||
| - name: golang-lint | ||
| env: | ||
| # prevent OOM | ||
| GOGC: 10 | ||
| uses: golangci/golangci-lint-action@v3.2.0 | ||
|
There was a problem hiding this comment. should we just do @latest here? There was a problem hiding this comment. Latest or perhaps @ v3 ? That way a major version upgrade wouldn't break the CI There was a problem hiding this comment. if it does break, we would know something changed in the action side. Times when this would break is when the underlying schema would change things the way this action is invoked or some new fields coming in. Irrespective it's good to do latest here as well IMO There was a problem hiding this comment. Makes sense! I pinned it to @ latest There was a problem hiding this comment. Interesting, @ latest is not possible (see the failed run here). But @ v3 works and will pull the latest minor versions There was a problem hiding this comment. they do have a There was a problem hiding this comment. you can probably just do |
||
| with: | ||
| # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. | ||
| version: v1.48 | ||
|
There was a problem hiding this comment. also should we just do latest here? There was a problem hiding this comment. latest can work here - currently latest is v1.50.1 so not a big bump There was a problem hiding this comment. it's easier if we pin to latest. We shouldn't be doing The other thing is there may be some There was a problem hiding this comment. Also pinned to latest. 👍 |
||
| only-new-issues: true | ||
| args: --timeout=10m | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 ^ thanks for adding this, could you also do this for
go-lint?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skrdgraph Sure, previously the linter yaml was skipping the Go installation step entirely with
skip-go-installation: true. I just pushed changes that model the linter after the Badger linter setup (hence the version bumps). Let me know if that looks okay.