Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix breaking tests #8413

Merged
merged 7 commits into from
Nov 4, 2022
Merged

chore(ci): fix breaking tests #8413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c74c34
fix breaking tests
joshua-goldstein Nov 4, 2022
b123b6f
revert name changes
joshua-goldstein Nov 4, 2022
bde4be5
modify linter
joshua-goldstein Nov 4, 2022
28e8fdb
bump linters to latest
joshua-goldstein Nov 4, 2022
f1e653f
modify dep
joshua-goldstein Nov 4, 2022
09cb73b
modify lint version
joshua-goldstein Nov 4, 2022
e4b79a0
revert
joshua-goldstein Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci-dgraph-load-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@ on:
jobs:
dgraph-load-tests:
if: github.event.pull_request.draft == false
runs-on: self-hosted
runs-on: [self-hosted, x64]
steps:
- uses: actions/checkout@v3
- name: Get Go Version
run: |
#!/bin/bash
GOVERSION=$({ [ -f .go-version ] && cat .go-version; })
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ^ thanks for adding this, could you also do this for go-lint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skrdgraph Sure, previously the linter yaml was skipping the Go installation step entirely with skip-go-installation: true . I just pushed changes that model the linter after the Badger linter setup (hence the version bumps). Let me know if that looks okay.

- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.18
go-version: ${{ env.GOVERSION }}
- name: Set up Node
uses: actions/setup-node@v3
with:
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/ci-dgraph-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@ on:
jobs:
dgraph-tests:
if: github.event.pull_request.draft == false
runs-on: self-hosted
runs-on: [self-hosted, x64]
steps:
- uses: actions/checkout@v3
- name: Get Go Version
run: |
#!/bin/bash
GOVERSION=$({ [ -f .go-version ] && cat .go-version; })
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.18
go-version: ${{ env.GOVERSION }}
- name: Set up Node
uses: actions/setup-node@v3
with:
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/ci-golang-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,23 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Get Go Version
run: |
#!/bin/bash
GOVERSION=$({ [ -f .go-version ] && cat .go-version; })
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GOVERSION }}
- name: golang-lint
env:
# prevent OOM
GOGC: 10
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.36
version: latest
only-new-issues: true
args: --timeout=10m
skip-go-installation: true