chore(ci): fix breaking tests #8413
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: ci-dgraph-load-tests-amd64 | ||
| on: | ||
| push: | ||
| branches: | ||
|
|
@@ -16,13 +16,18 @@ on: | |
| jobs: | ||
| dgraph-load-tests: | ||
| if: github.event.pull_request.draft == false | ||
| runs-on: [self-hosted, x64] | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Get Go Version | ||
| run: | | ||
| #!/bin/bash | ||
| GOVERSION=$({ [ -f .go-version ] && cat .go-version; }) | ||
| echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV | ||
|
There was a problem hiding this comment. +1 ^ thanks for adding this, could you also do this for There was a problem hiding this comment. @skrdgraph Sure, previously the linter yaml was skipping the Go installation step entirely with |
||
| - name: Set up Go | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: ${{ env.GOVERSION }} | ||
| - name: Set up Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshua-goldstein - can we remove this line change?
I had mentioned this to @adityasadalage, and indicated to specify the
x64, and not change the name.We will lose history when we make a name change. Also, the future plan is to use
matrixand bring in all the runner types into this workflow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skrdgraph yeah I wasn't sure on this point - I just reverted the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ci-dgraph-tests-arm64.yml pipeline was given the new name. Would that need to be reverted to accommodate the matrix change later on?