fix(test) add cleanup at start #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrdgraph
requested review from
akon-dey,
gcxml,
darkn3rd and
meghalims
as code owners
joshua-goldstein
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Looks good. This is a fix for the issue described in this PR.
dshekhar95
pushed a commit
that referenced
this pull request
Sep 19, 2022
* add cleanup at start * bring in changes from #8301 * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
so the current issue is the cleanup step does not work because crufts left by
load-testare in sudo user group. The action runner cannot clean those because of user perm issues. This was the original PR #8301 which I closed, but in hindsight had the right fix. The fix details are referenced in the solution section.Solution
this is an elegant way to clean it, because the underlying container runs in sudo-ers group.