fix(ci): add cleanup step #8301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
requested review from
akon-dey,
gcxml,
skrdgraph,
darkn3rd and
meghalims
as code owners
|
@joshua-goldstein don't close this PR - till we are very sure everything is consistent. This PR may come in handy. |
|
This was a good fix, we are accommodating this into the load test PR |
skrdgraph
added a commit
that referenced
this pull request
Sep 16, 2022
skrdgraph
added a commit
that referenced
this pull request
Sep 16, 2022
* add cleanup at start * bring in changes from #8301 * cleanup
dshekhar95
pushed a commit
that referenced
this pull request
Sep 19, 2022
* add cleanup at start * bring in changes from #8301 * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dgraph CI tests were failing overnight during the Github actions/checkout setup. This looks like a small, common issue. See here and here.
Solution
Add a cleanup job before running the actual tests.