Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contractLocation field to transaction output #61

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Feb 3, 2023

This (combined with an upcoming PR in Evmconnect and FireFly Core) brings the contract address of a deployed contract all the way through to the transaction output. This shows up in a JSONAny field called contractLocation and looks like this in FireFly:

...
    "output": {
        "Headers": {
            "requestId": "default:aa155a3c-2591-410e-bc9d-68ae7de34689",
            "type": "TransactionSuccess"
        },
        "contractLocation": {
            "address": "0x24746b95d118b2b4e8d07b06b1bad988fbf9415d"
        },
        "protocolId": "000000000024/000000",
        "transactionHash": "0x32d1144091877266d7f0426e48db157e7d1a857c62e6f488319bb09243f0f851"
    },
...

@codecov-commenter
Copy link

Codecov Report

Merging #61 (1f0341c) into main (8f3be12) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          59       59           
  Lines        3231     3233    +2     
=======================================
+ Hits         3230     3232    +2     
  Misses          1        1           
Impacted Files Coverage Δ
pkg/fftm/policyloop.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I did see a capital H in your sample, which might be worth looking at (although I don't see any evidence you introduced that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants