Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contractLocation to receipts #50

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Feb 3, 2023

This is the evmconnect portion of hyperledger/firefly-transaction-manager#61 to take advantage of the new field

@codecov-commenter
Copy link

Codecov Report

Merging #50 (149ef19) into main (d8c74b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   97.62%   97.63%           
=======================================
  Files          23       23           
  Lines        1391     1396    +5     
=======================================
+ Hits         1358     1363    +5     
  Misses         25       25           
  Partials        8        8           
Impacted Files Coverage Δ
internal/ethereum/get_receipt.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbroadhurst peterbroadhurst merged commit 36a74bd into hyperledger:main Feb 3, 2023
@peterbroadhurst peterbroadhurst deleted the contract-location branch February 3, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants