fixing get status method #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
Chengxuan
requested review from
peterbroadhurst,
awrichar,
nguyer and
dechdev
as code owners
Signed-off-by: Chengxuan Xing <[email protected]>
4 tasks
shorsher
reviewed
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chengxuan Xing [email protected]
The current
getStatusmethod calls the wrong global/statusAPI which returns the status of the default namespace rather than the one configured when Firefly SDK is initialised.I think this is a bug based on the convention that all methods should be under the namespace scope.
I also added a
getDefaultNamespaceStatusas I don't know an API that returns information about whether a namespace is the default namespace.