Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udpate sandbox UI to support mult-namespaces #108

Merged
merged 9 commits into from
Jan 9, 2023
Merged

udpate sandbox UI to support mult-namespaces #108

merged 9 commits into from
Jan 9, 2023

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Jan 8, 2023 •
edited
Loading

Signed-off-by: Chengxuan Xing [email protected]

Todos:

inputs are welcome on whether the following two logic are good enough:

  • (discussion) currently the code add the query with namespace to all rest request in fetch util.
  • (discussion) When a namespace is switched, a page reload is triggered.

@Chengxuan Chengxuan changed the title udpate sandbox UI to have a namespace dropdown udpate sandbox UI to support mult-namespaces Jan 8, 2023
@Chengxuan
add logic for dummy reload, auto detect default namespace
9123776 
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan
fixing websocket
8939fdd 
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan
change the localstorage item name
f8a5e2d 
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan
clean up PR
a760fd8 
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan Chengxuan marked this pull request as ready for review January 9, 2023 15:18
@matthew1001 matthew1001 mentioned this pull request Jan 9, 2023
Closed
@Chengxuan
remove extra space
36feecd 
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan
fixing forbid syntax
138e063 
Signed-off-by: Chengxuan Xing <[email protected]>
dechdev
dechdev approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@dechdev dechdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments, but they're quality-of-life rather than functional requests. Looks great otherwise

server/src/controllers/common.ts Outdated Show resolved Hide resolved
server/src/controllers/websocket.ts Outdated Show resolved Hide resolved
ui/src/App.tsx Outdated Show resolved Hide resolved
@Chengxuan
address review comments
972ad92 
Signed-off-by: Chengxuan Xing <[email protected]>
@dechdev dechdev merged commit ef69648 into hyperledger:main Jan 9, 2023
@Chengxuan Chengxuan deleted the multi-ns branch January 9, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dechdev dechdev dechdev approved these changes

@shorsher shorsher Awaiting requested review from shorsher

@peterbroadhurst peterbroadhurst Awaiting requested review from peterbroadhurst

@awrichar awrichar Awaiting requested review from awrichar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chengxuan @dechdev