Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3015: Support for niche optimization in FFI #3336

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Mar 29, 2023

Description

Linked issue

Closes #3015

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 29, 2023
@mversic mversic force-pushed the ffi_unsafe_refactor branch 2 times, most recently from c81c93e to 1a587f0 Compare March 29, 2023 13:22
@mversic mversic changed the title [refactor]: Don't derive unsafe traits [refactor] #3015: Support for niche optimization in FFI Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #3336 (9744f20) into iroha2-dev (a4d5c9f) will decrease coverage by 7.18%.
The diff coverage is 45.03%.

@@              Coverage Diff               @@
##           iroha2-dev    #3336      +/-   ##
==============================================
- Coverage       62.33%   55.16%   -7.18%     
==============================================
  Files             169      156      -13     
  Lines           31218    30204    -1014     
==============================================
- Hits            19459    16661    -2798     
- Misses          11759    13543    +1784     
Impacted Files Coverage Δ
cli/src/lib.rs 0.28% <0.00%> (-69.16%) ⬇️
cli/src/main.rs 0.85% <0.00%> (-0.25%) ⬇️
cli/src/samples.rs 0.00% <0.00%> (-61.85%) ⬇️
cli/src/torii/mod.rs 0.00% <0.00%> (-27.66%) ⬇️
cli/src/torii/routing.rs 0.00% <0.00%> (-57.11%) ⬇️
cli/src/torii/utils.rs 0.00% <0.00%> (-84.85%) ⬇️
client/src/http_default.rs 0.00% <0.00%> (-38.94%) ⬇️
client_cli/src/main.rs 0.25% <0.00%> (+<0.01%) ⬆️
config/base/src/lib.rs 91.57% <ø> (+55.21%) ⬆️
config/src/lib.rs 33.33% <ø> (ø)
... and 103 more

... and 43 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mversic mversic force-pushed the ffi_unsafe_refactor branch from 1a587f0 to 4e1fcbf Compare March 29, 2023 18:28
@mversic mversic force-pushed the ffi_unsafe_refactor branch from 4e1fcbf to cd2e359 Compare March 30, 2023 05:49
@mversic mversic marked this pull request as ready for review March 30, 2023 05:50
@mversic mversic changed the title [refactor] #3015: Support for niche optimization in FFI [feature] #3015: Support for niche optimization in FFI Mar 30, 2023
@mversic mversic force-pushed the ffi_unsafe_refactor branch 4 times, most recently from 4f73bdd to aa3c070 Compare March 30, 2023 06:30
@mversic mversic force-pushed the ffi_unsafe_refactor branch from aa3c070 to 3f4e756 Compare March 30, 2023 08:38
@mversic mversic self-assigned this Mar 30, 2023
@mversic mversic force-pushed the ffi_unsafe_refactor branch from 3f4e756 to 0c2aa71 Compare March 30, 2023 10:57
@Arjentix Arjentix self-assigned this Mar 30, 2023
@mversic mversic force-pushed the ffi_unsafe_refactor branch 6 times, most recently from 3536264 to a6077f2 Compare April 12, 2023 12:24
@mversic mversic requested review from Arjentix and appetrosyan April 12, 2023 13:26
@mversic mversic force-pushed the ffi_unsafe_refactor branch 5 times, most recently from 96edd35 to 825a371 Compare April 14, 2023 03:20
Arjentix
Arjentix previously approved these changes Apr 14, 2023
appetrosyan
appetrosyan previously approved these changes Apr 17, 2023
@mversic mversic dismissed stale reviews from appetrosyan and Arjentix via df383b9 April 18, 2023 05:35
@mversic mversic force-pushed the ffi_unsafe_refactor branch from 825a371 to df383b9 Compare April 18, 2023 05:35
@mversic mversic merged commit 4da5b48 into hyperledger-iroha:iroha2-dev Apr 20, 2023
@mversic mversic deleted the ffi_unsafe_refactor branch April 20, 2023 07:15
appetrosyan pushed a commit that referenced this pull request Jun 5, 2023
mversic added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants