Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transmuting hash into array #3386

Closed
mversic opened this issue Apr 18, 2023 · 2 comments
Closed

Transmuting hash into array #3386

mversic opened this issue Apr 18, 2023 · 2 comments
Labels
help wanted Extra attention is needed iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Apr 18, 2023 •
edited
Loading

Do you think there could be any issue with treating Hash as transmutable into [u8; Hash::LENGTH] considering it's a repr(C) struct with two fields?

I'm slightly concerned about the effects on the calling convention, though probably that's not an issue

Originally posted by @mversic in #3336 (comment)
@mversic mversic added help wanted Extra attention is needed question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 18, 2023
@mversic
Copy link
Contributor Author

mversic commented Apr 18, 2023

relevant discussion

@appetrosyan
Copy link
Contributor

AFAICT, this is an upstream issue. cbindgen is relatively young and IMO this will remain an open question for a while.

@appetrosyan appetrosyan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @mversic