-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD BORT #9813
ADD BORT #9813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! And good timing as well - adding the 40th model architecture when stars hit 40K!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great. The integration tests are a fantastic addition, too. Thanks for taking care of it @stefan-it, and congrats for adding the 40th model to Transformers 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this new model! When referencing other pages in the documentation, it's better to use :doc:
instead of a hard link, as it will then work in all versions of the documentation (which don't have the same base url).
Co-authored-by: Sylvain Gugger <[email protected]>
Co-authored-by: Sylvain Gugger <[email protected]>
Sorry that was my bad! I copied it from DialoGPT -> Updated it there as well |
Ah sorry @patrickvonplaten, the |
Co-authored-by: Patrick von Platen <[email protected]>
Great job @stefan-it |
* tests: add integration tests for new Bort model * bort: add conversion script from Gluonnlp to Transformers 🚀 * bort: minor cleanup (BORT -> Bort) * add docs * make fix-copies * clean doc a bit * correct docs * Update docs/source/model_doc/bort.rst Co-authored-by: Sylvain Gugger <[email protected]> * Update docs/source/model_doc/bort.rst Co-authored-by: Sylvain Gugger <[email protected]> * correct dialogpt doc * correct link * Update docs/source/model_doc/bort.rst * Update docs/source/model_doc/dialogpt.rst Co-authored-by: Patrick von Platen <[email protected]> * make style Co-authored-by: Patrick von Platen <[email protected]> Co-authored-by: Sylvain Gugger <[email protected]>
Hi,
this is a "clean" follow-up PR to the first attempt of adding Bort to Transformers (see #9112).
As Bort is based on the BERT architecture, there's no need to define own model classes, such as
BortModel
. This is done in the main Bort configuration via:Bort uses the same vocab as RoBERTa, so the tokenizer instance is also configured in the model configuration:
Basic integration tests and a (hopefully verbose) conversion script are also included in this PR.