-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dataloader wrappers to have total_batch_size
attribute
#493
update dataloader wrappers to have total_batch_size
attribute
#493
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a useful addition, but I'd prefer have this as a property and no new arguments in the init that aren't really used to influence the behavior of the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean!
Co-authored-by: Sylvain Gugger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Seems quite useful indeed. My main concern here is that everything is documented properly given we're adding a new property to every dataloader type.
Worrying about the XLA wrapper in the docs is something we can discuss a bit later.
Co-authored-by: Zachary Mueller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
What does this PR do?
accelerator.prepare
call. Addingtotal_batch_size
to provide the resulting batch_size across devices.