Generated: execute yarn lint --fix
#575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated: execute
yarn lint --fix
Follow-up to hotwired/turbo#573.
ESLint support was recently merged and integrated in to the Continuous
Integration checks, but excluded several existing linting violations.
This commit's diff was generated by executing
yarn lint --fix
.These violations were discovered when rebasing hotwired/turbo#436.
Once this is passing and merged, these changes will be rebased into that
branch's changeset.
Resolve failing
FormSubmissionTest
There is a race condition in the
FormSubmissionTest
file's coveragefor confirmation. If evaluated quickly enough, the test's assertions
might be checked before the subsequent Turbo Driver navigation occurs,
which would fail the check for the Form Submission's change to the
current path.
This commit adds an additional
await
expression to wait until the nextturbo:load event to fire, so that the entire navigation can complete
before the assertions are evaluated.