-
Notifications
You must be signed in to change notification settings - Fork 436
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Generated: execute
yarn lint --fix
(#575)
* Generated: execute `yarn lint --fix` Follow-up to [#573][]. ESLint support was recently merged and integrated in to the Continuous Integration checks, but excluded several existing linting violations. This commit's diff was generated by executing `yarn lint --fix`. These violations were discovered when rebasing [#436][]. Once this is passing and merged, these changes will be rebased into that branch's changeset. [#573]: #573 [#436]: https://github.com/hotwired/turbo/pull/436/files * Resolve failing `FormSubmissionTest` There is a race condition in the `FormSubmissionTest` file's coverage for confirmation. If evaluated quickly enough, the test's assertions might be checked before the subsequent Turbo Driver navigation occurs, which would fail the check for the Form Submission's change to the current path. This commit adds an additional `await` expression to wait until the next [turbo:load][] event to fire, so that the entire navigation can complete before the assertions are evaluated. [turbo:load]: https://turbo.hotwired.dev/reference/events
- Loading branch information
1 parent
933419b
commit f67eb3a
Showing
4 changed files
with
8 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters