-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename docker-compose.yml files #1998
Rename docker-compose.yml files #1998
Conversation
Signed-off-by: casdal <[email protected]>
Signed-off-by: casdal <[email protected]>
Signed-off-by: casdal <[email protected]>
This is great! Thank you π I think one small thing might be missing as far as I can tell. Updating the build and deploy github workflow that references docker-compose.{environment}. We use this for the deploy step =) |
Hi , Thank to you btw |
Hi @spwoodcock, hotosm/gh-workflows#59 (comment) Shoud I also change references to : |
Apologies @casdal ! The missing part here is the variable defined in the FMTM usage of the workflows: fmtm/.github/workflows/build_and_deploy.yml Line 158 in 1d0a0a2
|
I also looks like a reference here too that might need updating:
|
No need to apologies @spwoodcock , I shoudl use '--hiden' while grepring π
If more work is needed, please just tell me. |
3d4b0c4
to
f4d5855
Compare
Signed-off-by: casdal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you π
Thank you to you. |
I think references in docs: gh-workflows/docker-compose.yml - gh-workflows/docker-compose.yml - gh-workflows/docker-compose.yml need to be updated for reflect the changes made here. There is a PR open on that repo #59 |
This reverts commit 1b1b1fb.
Apologies @casdal , I'm currently on holiday & the team had to revert the changes here temporarily π«£ I think there is a nested reference to the original filename in one of out github workflows that needs to be changed, before this PR will work. We will get back to you in the new year! |
Hi @spwoodcock ,
No problem
I will investigate, thanks for the hints btw. |
* Rename docker-compose.yml files Signed-off-by: casdal <[email protected]> * Delete docker-compose.yml files Signed-off-by: casdal <[email protected]> * Rename docker files and references to them. Signed-off-by: casdal <[email protected]> * Rename references to compose.yaml on github workflows. Signed-off-by: casdal <[email protected]> --------- Signed-off-by: casdal <[email protected]>
What type of PR is this? (check all applicable)
Related Issue
Fixes #1769
Describe this PR
Rename docker-compose.yml files and references to them.
[optional] What gif best describes this PR or how it makes you feel?
π