Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docker-compose.yml files --> compose.yaml #1769

Closed
spwoodcock opened this issue Sep 4, 2024 · 7 comments · Fixed by #1998
Closed

Rename docker-compose.yml files --> compose.yaml #1769

spwoodcock opened this issue Sep 4, 2024 · 7 comments · Fixed by #1998
Assignees
Labels
devops Related to deployment or configuration effort:low Likely a few hours good first issue Good for newcomers priority:low Backlog of tasks that will be addressed in time

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Sep 4, 2024

Issue

  • Docker compose recently made the default compose file compose.yml instead of docker-compose.yml.
  • docker-compose.yml may be deprecated in future? It's also docker-centric, when we may want to use OCI tools such as Podman compose.

Solution

  • Rename all docker-compose.yml files --> compose.yaml.
  • Update all references to docker-compose file to the new file names.
    • In this repo.
    • Plus in fmtm-installer sh script.

Note

yaml extension is also preferred over yml in the official YAML spec.

@spwoodcock spwoodcock added good first issue Good for newcomers priority:low Backlog of tasks that will be addressed in time devops Related to deployment or configuration effort:low Likely a few hours labels Sep 4, 2024
@spwoodcock spwoodcock added this to the Update production devops milestone Sep 4, 2024
@spwoodcock spwoodcock changed the title Rename docker-compose.yml files --> compose.yml Rename docker-compose.yml files --> compose.yaml Sep 4, 2024
@casdal
Copy link
Contributor

casdal commented Dec 16, 2024

Hi there @spwoodcock ,

I would love to work in this one.
Can you please assign it to me.

@spwoodcock
Copy link
Member Author

Sure!

Thanks @casdal 😁

@casdal
Copy link
Contributor

casdal commented Dec 17, 2024

Hi @spwoodcock,

should I need to modify also this files ?

docker-compose.development.yml
docker-compose.main.yml
docker-compose.staging.yml

@spwoodcock
Copy link
Member Author

Hi @spwoodcock,

should I need to modify also this files ?

docker-compose.development.yml docker-compose.main.yml docker-compose.staging.yml

Yes please! 🎉

@casdal
Copy link
Contributor

casdal commented Dec 17, 2024

Thanks you @spwoodcock,

If something need some more work, please just tell me.
#1998

@spwoodcock
Copy link
Member Author

@all-contributors
add @casdal for code

Copy link
Contributor

@spwoodcock

I've put up a pull request to add @casdal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to deployment or configuration effort:low Likely a few hours good first issue Good for newcomers priority:low Backlog of tasks that will be addressed in time
Projects
Development

Successfully merging a pull request may close this issue.

2 participants