Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working submission comments to submission page #1709

Merged
merged 17 commits into from
Jul 29, 2024
Merged

Add working submission comments to submission page #1709

merged 17 commits into from
Jul 29, 2024

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Jul 26, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains the following works:

  1. Project Submissions UI enhancement
  2. Submission comment integration

Screenshots

image
image

NSUWAL123 added 13 commits July 26, 2024 10:12
@NSUWAL123
fix(submissionDetails): display start, end, today date, deviceid sepe…
1cf75c4 
…rately above
@NSUWAL123
fix(accordion): add seperator props
ede308c
@NSUWAL123
fix(submissionDetails): use accordion to display nested values, code …
8b13559 
…refactor
@NSUWAL123
fix(submissionTable): change submission taskId key
f9e3558
@NSUWAL123
fix(submissionsTable): redirect to submission instance page with taskUId
4acf0ac
@NSUWAL123
fix(submission): pass taskUId while reviewStateModal dispatch
5c83bef
@NSUWAL123
feat(assetModules): calendar icon add
b558c79
@NSUWAL123
fix(submissionComments): submission comments component add
b10e5ec
@NSUWAL123
fix(submissionDetails): fix UI, submissionComments component add
fc58087
@NSUWAL123
feat(updateReviewStatusModal): add comments api integration
1cc8756
@NSUWAL123
fix(projectInfo): fix index access
4abd564
@NSUWAL123
fix(submissionService): remove clear reviewStatusState & loading stat…
fad1437 
…e remove from service
@NSUWAL123
fix(comments): filter task comments only
fdc0df2
@github-actions github-actions bot added the frontend Related to frontend code label Jul 26, 2024
@NSUWAL123 NSUWAL123 marked this pull request as ready for review July 29, 2024 05:03
@NSUWAL123 NSUWAL123 requested a review from spwoodcock July 29, 2024 05:03
@spwoodcock spwoodcock changed the title Fix/submission instance UI refactor Add working submission comments to submission page Jul 29, 2024
@spwoodcock spwoodcock merged commit 9d08533 into hotosm:development Jul 29, 2024
4 checks passed
@NSUWAL123 NSUWAL123 mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
frontend Related to frontend code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSUWAL123 @spwoodcock