Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to view the commented message during submission validation #1617

Closed
manjitapandey opened this issue Jul 2, 2024 · 5 comments
Closed
Assignees
Labels
bug Something isn't working effort:medium Likely a day or two frontend Related to frontend code priority:high Should be addressed as a priority testing:ready Ready for testing

Comments

@manjitapandey
Copy link
Contributor

Describe the bug
During the submission validation, I can post the comment on individual submission but there is no place for users to view those submissions.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'submission table page'
  2. Click on 'tick icon on right of each submission to comment'
  3. but the comment are not visible anywhere
  4. See error

Expected behavior
The comment section should be added on submission details page to view the comments on those submission.

Screenshots
image

@manjitapandey
Copy link
Contributor Author

blocked by : #1694

@NSUWAL123
Copy link
Contributor

NSUWAL123 commented Jul 25, 2024

Let's finalize which comment to use in this submission instance page. Either task comment or submission comment.
If the submission comment is to be used it might take a while as it involves backend too.

Or else, we could hide the notes & comments section on review status modal as there's no API for submission comments.
image

cc: @spwoodcock, @manjitapandey

@spwoodcock
Copy link
Member

Let's use task comments, so this will be a task history entry of type COMMENT, but to distinguish it as a submission comment we can have the comment start with |SUBMISSION|.

Then when we load the comments on the frontend we can split out these comments into a separate array.

We could possibly update this in the future to have a separate action SUBMISSION_COMMENT

@manjitapandey
Copy link
Contributor Author

submission comment on the submission instance page
On the submission instance page, user should be able to add comment for that specific submission. The submission comment would be posted from this very page. But the question would be where and how to visualise the submission comments posted here. The UI I have thought was to visualise it on submission details page as posted in image above. But Sam's suggestion was to view submissions comment on project detail page comment section by providing the entity id.
Let's wait for @spwoodcock confirmation before we move ahead.

@spwoodcock
Copy link
Member

I think it's fine as you suggested Manjita - submit and view on the submission page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:medium Likely a day or two frontend Related to frontend code priority:high Should be addressed as a priority testing:ready Ready for testing
Projects
Development

No branches or pull requests

3 participants