Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission review status error message should disappear once the status selected #1720

Closed
manjitapandey opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working effort:low Likely a few hours frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time testing:ready Ready for testing

Comments

@manjitapandey
Copy link
Contributor

Describe the bug
Following from the issue #1617 , if user add a comment on submission without adding the submission status, an error message is shown saying "Review status needs to be selected". However, even after selecting the submission status , the error message is not removed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'submission details page'
  2. Click on 'Update review status'
  3. add comment without adding review status
  4. Again change review status
  5. See error

Expected behavior
The error message should be cleared, once the review status is added.

Screenshots
image

Additional context
The addition of comment without adding review status is not an ideal user behavior so I am adding this issue on low priority.

Also would it be okay if we disable the submit button unless the review status is added?

@manjitapandey manjitapandey added bug Something isn't working priority:low Backlog of tasks that will be addressed in time effort:low Likely a few hours frontend Related to frontend code labels Jul 30, 2024
@NSUWAL123 NSUWAL123 self-assigned this Aug 2, 2024
@spwoodcock spwoodcock changed the title error message should disappear once the state is changed Submission review status error message should disappear once the status selected Aug 2, 2024
@NSUWAL123 NSUWAL123 added the testing:ready Ready for testing label Aug 5, 2024
@manjitapandey
Copy link
Contributor Author

The update button is disabled until the submission status is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:low Likely a few hours frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time testing:ready Ready for testing
Projects
None yet
Development

No branches or pull requests

2 participants