Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deno): merge deno runtime coverage #3632

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

usualoma
Copy link
Member

@usualoma usualoma commented Nov 6, 2024

A re-creation of #3456 in a new branch.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (0a18c02) to head (48bddfa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3632      +/-   ##
==========================================
+ Coverage   89.80%   90.52%   +0.72%     
==========================================
  Files         159      159              
  Lines       10120    10179      +59     
  Branches     2793     2843      +50     
==========================================
+ Hits         9088     9215     +127     
+ Misses       1032      962      -70     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usualoma
Copy link
Member Author

usualoma commented Nov 6, 2024

@yusukebe

There are some minor additions due to the output results for each coverage tool, but I don't think there will be any major problems.
And we can see that the code coverage for deno is now being measured.
How about merging this content?

CleanShot 2024-11-06 at 13 05 20@2x

@usualoma usualoma marked this pull request as ready for review November 6, 2024 04:09
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Nov 6, 2024

Hi @usualoma

How about merging this content?

This is good! Merging now. Thanks!

@yusukebe yusukebe changed the title chore(test): merge deno runtime coverage ci(deno): merge deno runtime coverage Nov 6, 2024
@yusukebe yusukebe merged commit ebd1a0e into honojs:main Nov 6, 2024
16 checks passed
@exoego exoego mentioned this pull request Nov 6, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants