Add support to "does-not-contain" operator on RulesBasedSampler #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Hey @tr-fteixeira - thanks for the contribution and sorry for the delay in getting back to you.
This looks good and I'm happy to accept it. I agree further work to better validate rules would be good and #266 is a good place to track that.
MikeGoldsmith
added
the
version: bump minor
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #265
Took must of the code from the "contains", including the test.
Let me know what you think, and if it needs anything else.
Docs and extra logging for unsupported operators to be added on 266 👍.