Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Validate operators supported on RulesBasedSampler when parsing the rules #266

Closed
tr-fteixeira opened this issue Jun 4, 2021 · 2 comments · Fixed by #701
Closed
Labels
type: enhancement New feature or request

Comments

@tr-fteixeira
Copy link
Contributor

This is related to #265 .

It would have been a LOT easier to understand why the rules were not being applied/evaluated properly if we had the indication that those are not supported.

This does not need to fail the parse, or could, this depends on the team preference for those failure modes. Let me know what you guys would prefer 👍

Regards,

@tr-fteixeira tr-fteixeira changed the title Enhancement: Validate operators supported when parsing the rules Enhancement: Validate operators supported on RulesBasedSampler when parsing the rules Jun 4, 2021
@vreynolds vreynolds added the type: enhancement New feature or request label Jul 26, 2021
@irvingpop
Copy link
Contributor

We're noticing a lot of customers are getting burned by Refinery silently ignoring rules that are malformed in any way. It's rather difficult to troubleshoot.

@irvingpop
Copy link
Contributor

Couple of recent examples, from customers who used the bad dot.notation examples from the helm repo. Namely these two:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants