Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span Events from OTLP are dropped #258

Closed
dstrelau opened this issue May 21, 2021 · 0 comments
Closed

Span Events from OTLP are dropped #258

dstrelau opened this issue May 21, 2021 · 0 comments

Comments

@dstrelau
Copy link
Member

It looks as if span.Events is never looked at here, meaning span events are just dropped on the floor 😢

https://github.com/honeycombio/refinery/blob/main/route/route.go#L446-L478
dstrelau added a commit that referenced this issue May 27, 2021
@dstrelau
Propagate span events. Fix #258
5a575b9
@dstrelau dstrelau mentioned this issue May 27, 2021
Merged
@zombispormedio zombispormedio mentioned this issue Jun 8, 2021
Closed
ghost pushed a commit to opsramp/tracing-proxy that referenced this issue Jul 5, 2024
@dstrelau
Propagate span events. Fix honeycombio#258 (honeycombio#261)
ec905ed 
Implements honeycombio#258 to pass through OTLP span events as regular events with meta.annotation_type: "span_event".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dstrelau