Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span Links from OTLP are dropped #268

Closed
zombispormedio opened this issue Jun 8, 2021 · 0 comments · Fixed by #264
Closed

Span Links from OTLP are dropped #268

zombispormedio opened this issue Jun 8, 2021 · 0 comments · Fixed by #264

Comments

@zombispormedio
Copy link

As span events in the past #258, span links are not taken into account.

https://github.com/honeycombio/refinery/blob/main/route/route.go#L446-L478

refinery/internal/opentelemetry-proto-gen/trace/v1/trace.pb.go

Line 369 in c07a83b

Links []*Span_Link `protobuf:"bytes,13,rep,name=links,proto3" json:"links,omitempty"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure span links and events generate events and get resource attrs honeycombio/refinery
1 participant
@zombispormedio