-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default widget layout #1641
Default widget layout #1641
Conversation
Don't forget to bring that |
I changed the text in all language versions (using Google translate). |
I will push a fix and see if it resolves it. |
@donavanbecker I just updated code. Can You try? (Child Bridge Widget x position should be 15, not 16). |
@grzegorz914 does beta.25 fix it? |
I think that Homebridge widget should be scrollable (like System info widget). |
@donavanbecker no, the problem still exist with b.25 |
@donavanbecker Child Bridge Widget x position should be 15, not 16. And there is no "Homebridge" word , only version. |
okay, I updated what you had @mkz212. If that doesn't work. I am going to revert back to what I had and see if it resolves it. |
that worked @mkz212. @grzegorz914 beta.26. How is that for you? |
@donavanbecker b.26 nothing changed but I can rearrange it and adapted to the screen. looks like the size is only dynamic in x size and for y size is static. |
@donavanbecker I wouldn't want to mess up too much now. Could you add this code? to /ui/src/scss/themes-dark.scss :
|
@grzegorz914 I think that problem is because this widget is not scroled like the widget system info. In the last stable version, with such a layout as you present it also does not display correctly for me - the widget is simply too narrow for this. |
added for next beta. |
|
do we need the word homebridge next to the version? the widget title is homebridge, is it not obvious? |
@bwp91 I thought it was a mistake. Ok. But I would change the text from: "Uruchomiony na porcie: 55555" to "Port: 55555". ![]() |
@mkz212, you have an option to hide that port also. |
Yes, I know, But I think this text is too long and looks better just: |
@mkz212, open a PR with these changes and I will merge |
beta 30 looks fantastic! |
My last approach to default look suggestion.