Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in widgets #1637

Merged
merged 12 commits into from
Nov 7, 2023
Merged

Small changes in widgets #1637

merged 12 commits into from
Nov 7, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 6, 2023

System info widget:

  • change of order (e.g. time zone is not so important to be first).
Zrzut ekranu 2023-11-6 o 19 42 43

Homebridge widget

  • change of order (system started / not startet - first, Homebridge - second).
  • Homebridge update information moved to the bottom line so that it is in accordance with the Plugins.
  • adding the name Homebridge permanently.
  • small corrections with margin and padding so that if someone wants this widget in a vertical version it will look better.
  • change icon about update node: from info to circle-up.
Zrzut ekranu 2023-11-6 o 19 40 56

QR code widget

  • Changing the text to a simpler one: "Skan to add to Homekit" (note: in some languages there is "Apple Home", and in some there is "Homekit").

@donavanbecker
Copy link
Contributor

For the Homebridge widget, I think we should make this customizable if you are wanting it changed. Just like we have the Display Port option on this widget.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 6, 2023

I don't quite understand? What exactly you want to make customizable?

@donavanbecker
Copy link
Contributor

I don't quite understand? What exactly you want to make customizable?

The ordering of Homebridge, System, Plugin.

@bwp91 bwp91 changed the base branch from latest to beta-4.52.2 November 7, 2023 08:35
@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

What I still miss in system info:

  • SSH and FTP : enabled / disabled, and info icon next to it and after click info how to SSH and how to conect via FTP.
  • info about updates of packages (apt update)
  • info about Homebridge Image version and latest image (check for update)
  • there should be only storage path: configuration path and plugins path should be as a tooltip or after click on info icon next to storage path
  • Number of bridges and devices: E.G.: 3 / 41

Maybe option to choose what elements should be visible?

@bwp91
Copy link
Contributor

bwp91 commented Nov 7, 2023

In general I like the changes proposed here.

A couple of things from me:

  • Can we keep the Scan this code with the camera on your iOS device to add to Apple Home. text change out of this PR and perhaps include it in Default widget layout #1641 PR?
  • There is a conflict in one of the files which needs updating
  • Perhaps the homebridge version could go next to Homebridge so that the text below can simply say 'Up to date' to match the plugins item (to the right or below) - the version part can still be a link to the modal to change version
    Screenshot 2023-11-07 at 09 31 54

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

  • ok, I restored the original text under QR code.
  • I changed as you advise (Homebridge v.1.7.0 in same line) I think it looks even better.

@bwp91 bwp91 merged commit 0d8aa29 into homebridge:beta-4.52.2 Nov 7, 2023
@donavanbecker
Copy link
Contributor

donavanbecker commented Nov 7, 2023

@mkz212 Something got messed up with the plugin link. Even if you didn't have any updates, you could "up to date" under plugin and it would take you to the plugin screens

@bwp91
Copy link
Contributor

bwp91 commented Nov 7, 2023

this was me ^ i can add it back

@donavanbecker
Copy link
Contributor

Sounds good thanks @bwp91!

@mkz212 mkz212 deleted the widgets branch November 9, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants