Integrate VeSync humidifiers

[jspayd]

Breaking change

Proposed change

• Integrates VeSync humidifiers
• Upgrades pyvesync to version 2.0.1. There is no changelog message, but upgrading allows us to look up what features humidifiers support. E.g., we can tell if humidifiers support a night light just by checking for the night_light property.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: VeSync new device support #44865 (closed, but only due to inactivity)
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io: Add documentation for VeSync humidifiers home-assistant.io#20901

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.

• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.

• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. - This is the latest changelog message. Most of the updates don't have changelog messages.

  Adding support for the Core300S air purifier and fix Azure Pipelines (https://github.com/webdjoe/pyvesync/releases/tag/1.4.2)

• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.
  • Add basic type hints to nissan_leaf #62904 (review)
  • Update stream errors with additional error information #62900 (review)

[homeassistant]

Hi @jspayd,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[decompil3d]

Thanks for your contribution! I have an open PR for this component, so I tried to note places where we can align to avoid merge conflicts later on.

[jspayd]

Considering there is another open PR for this integration (#61837), I'm going to wait a while before making the requested changes. I'm hoping that the other PR is merged soon so that I can rebase and then make changes, since that should be easier than trying to make the merge clean by eye and then still having to do some work when I rebase.

[jspayd]

Other PR was merged, so I rebased and made the recommended changes. Still need to update my docs PR.

[jspayd]

Updated docs

[decompil3d]

Tiny nit on a doc comment but otherwise LGTM. Thanks for waiting on my other PR and integrating really nicely with those changes.

[jspayd]

Tiny nit on a doc comment but otherwise LGTM. Thanks for waiting on my other PR and integrating really nicely with those changes.

Fixed. Thanks for reviewing!

[heebnerd]

I think you could also add "Dual200S": "humidifier", to this list

[jspayd]

While it looks like the master branch of pyvesync has Dual200S support, the PR for that was just merged two weeks ago (webdjoe/pyvesync#104), so it's not in the latest release, which is from November. This should be possible after the next pyvesync release, though.

[borpin]

I have found my Humidifier, ostensibly a Dual200S is reporting as "LUH-D301S-WEU" so it would be good to add that model as well.

From pyvesync V2.0.0;

{
	"Device Name": "Study Hum",
	"Model": "LUH-D301S-WEU",
	"Subdevice No": "None",
	"Status": "on",
	"Online": "online",
	"Type": "wifi-air",
	"CID": "vsaqxxxxxxxxxxxxxxxxxxxxxxx",
	"Mode": "auto",
	"Humidity": "40",
	"Mist Virtual Level": "1",
	"Mist Level": "1",
	"Water Lacks": false,
	"Humidity High": false,
	"Water Tank Lifted": false,
	"Display": true,
	"Automatic Stop Reach Target": true,
	"Auto Target Humidity": "42",
	"Automatic Stop": true
}

Because pyvesync just returns the model, every possible model as listed here in each group probably needs to be included.

[johndbritton]

What does this PR need to be merged? Anything I can do to help?

[jspayd]

What does this PR need to be merged? Anything I can do to help?

I think it just needs review by a maintainer. This is my first Home Assistant PR, so I'm not completely sure how long that normally takes or what the process is like.

[decompil3d]

The maintainers often seem to review PRs in bursts, often right before a new release. So I'd expect reviews next week ahead of the 2/2 release.

[borpin]

1. mist level step (I think I saw in docs the default was 1 and let it use the default, but it looks like it ended up not being 1? I'll have to take a closer look)

https://developers.home-assistant.io/docs/core/entity/number If the difference is one, the step will be 0.1.

@jspayd, @vlebourl has done a whole load of work on this via custom integration which started from this PR. You might want to take a look. https://github.com/vlebourl/custom_vesync

Also, the Python library has been bumped to fix a couple of bugs.

[jakeasmith]

Heya! Just jumping in with another “this is gonna be awesome!” Any chance of this making it into the next release?

[borpin]

Heya! Just jumping in with another “this is gonna be awesome!” Any chance of this making it into the next release?

You can install an updated version via HACS (will just work instead of the core version). https://github.com/vlebourl/custom_vesync

HACS version will work better than the core version, even when this PR eventually gets released as this is still missing functionality.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[NickM-27]

Bump

[2opremio]

What's left for this to be merged? (apart from fixing the conflicts). I would really benefit from it (and @jspayd put a whole lot of effort into it).

[borpin]

I would really benefit from it

Don't hold your breath. I'd just use the custom integration https://github.com/vlebourl/custom_vesync

[cdnninja]

I am going to try bump this back up. @jspayd Any chance you can resolve the merge conflicts as a start? I can give this a test soon to confirm still working.

[chuckdeal97]

I'm looking for some help, I don't have a strong git background, and I'm not sure how to proceed.

I was following an article I found to add to someone else's pull request (https://tighten.com/insights/adding-commits-to-a-pull-request/) and did a checkout of jspayd's branch. I then followed the steps described at https://developers.home-assistant.io/docs/development_catching_up/ for rebasing. That branch was MANY months out-of-date and there were a number of conflicts and underlying code improvements. I tried the final step of pushing the rebased changes to jspayd's branch but received permission denied.

➜ hass-core git:(jspayd-vesync-humidifier) git push jspayd HEAD:vesync-humidifier --force-with-lease
remote: Permission to jspayd/core.git denied to chuckdeal97.
fatal: unable to access 'https://github.com/jspayd/core.git/': The requested URL returned error: 403

I now have my own branch (https://github.com/chuckdeal97/hass-core/tree/jspayd-vesync-humidifier) that I am not sure how to use to push this PR ahead.

[decompil3d]

You can't push to her branch but you can set the base of your PR to her branch and open it against her fork. Or you can just open a fresh PR against the upstream (here) and note the PR number here so the maintainers can close this one if appropriate.

[chuckdeal97]

For those following this PR, I'm attempting to merge the base content from the PR with PR #84025 .

The active PR for supporting humidifiers is #88941

[chuckdeal97]

I'd recommend closing this PR in favor of a newer set of PRs that have been opened to cover the same functionality (#90455)

[epenet]

There are merge conflicts that need resolving.
Please rebase or consider closing in favor of #90455

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.