Add support for VeSync Humidifiers #84025
Conversation
|
Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
kevin-brown
force-pushed
the
vesync-humidifier
branch
4 times, most recently
from
0c282f6 to
47f0259
Compare
kevin-brown
force-pushed
the
vesync-humidifier
branch
2 times, most recently
from
ed30a2c to
66c73ab
Compare
kevin-brown
force-pushed
the
vesync-humidifier
branch
from
3ec8c06 to
79e65ba
Compare
|
fwiw, I pulled this PR locally and tested it too. The humidifier entity appeared without any problems and actions worked fine (turn on/off, set humidity level). |
|
Tested against my LUH-A602S-WUSR and functionality looks good. Was able to toggle the humidifier on and off as well as setting the target humidity level. |
|
any updates when this will be pushed into HA for those of use that don't know how to use this now? |
|
any updates? |
|
This also worked on my setup with the OASISMIST, more than happy to help with whatever it takes to get over the finish line |
This adds the entity registries and handlers for humidifier entities, as well as the base class that they will later extend from. Because humidifiers are a sub-type of fans within VeSync, we have to detect fans that are humidifers and not air purifiers by checking to see if they have the ability to set their humidity. If they can't set their target humidity, then they must be an air purifier, otherwise we are treating it like a humidfier. This also only adds support for the Classic300S but later support will be added for the other humidifiers supported by PyVeSync once support for that one is stabilized.
This adds support for the normal, auto, and sleep modes which are available across the supported humidifiers. Depending on the humidifier, the auto mode is also sometimes called humidity mode. Because of PyLint rules present within the project to avoid importing from sub-modules of a component, the `MODE_SLEEP` constant is now exposed from the root of the humidifier component. This is necessary to allow us to support sleep mode of humidifiers, something which it appears nobody else has done before.
This is needed because humidifiers within Home Assistant by default only support returning the target humidity, but not the current humidity. So you need to return it within a different sensor.
kevin-brown
force-pushed
the
vesync-humidifier
branch
from
79e65ba to
debe6db
Compare
|
Hi @bdraco, since you reviewed similar PRs on this integration, do you mind taking a look at this PR to get it merged? Thanks! |
|
I'd recommend closing this PR in favor of a newer set of PRs that have been opened to cover the same functionality (#90455) |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Add support VeSync humidifiers which are supported by the underlying PyVesync library.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: