Fix ChatFeed / Interface tests and async generator placeholders #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6245 +/- ##
==========================================
+ Coverage 82.68% 84.19% +1.51%
==========================================
Files 301 301
Lines 45099 45137 +38
==========================================
+ Hits 37288 38004 +716
+ Misses 7811 7133 -678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I manually tested this branch on a few examples: Screen.Recording.2024-01-19.at.11.05.48.AM.movScreen.Recording.2024-01-19.at.11.06.34.AM.movScreen.Recording.2024-01-19.at.11.08.31.AM.mov |
philippjfr
reviewed
Jan 20, 2024
ahuang11
commented
Jan 20, 2024
philippjfr
approved these changes
Jan 20, 2024
philippjfr
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Fix chat issues * Lower timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the tests actually run and raises errors by setting
callback_exception = "raise"rather than having the errors piped to the chat logsThis resulted in finding a lot of tests failing, but most of them were just tests not written properly (e.g. not using
wait_untilto assert)The only bug I found was a result of #6105, where async generator functions execution time was based on
placeholder_threshold, i.e.await _schedule_placeholderhad to run in completion, before the actual callback started executing.This was remedied by wrapping
_serialize_response(where the iteration of the generator was happening) alongside the actual callback so that when checkingtask.done(), it checks the execution of both of these.