Fix generator placeholder and optimize updates #6105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generator tasks, the condition
while not task.done() and num_entries == len(self._chat_log):
leads to tasks completing almost instantly, as generators are lazily evaluated. Consequently, relying ontask.done()
becomes unreliable.When using
submit_task(generator)
, thestate.FiNISHED
is quickly reached because, technically, the generator is lazily evaluated and returned. To illustrate, the generator is considered "finished" in a mere 1.33 microseconds, as depicted in the image below:So it's not reliable to depend on
task.done()
Instead, we should usecallback_state.IDLE
to track business (when re-reading this, I was confused and realized, business -> busy-ness)Also, this updates how the placeholder text gets updated.
Addresses
https://discourse.holoviz.org/t/spinning-icon-effect-that-appears-when-the-user-sends-a-message-in-chatinterface/6582/10?u=ahuang11