Fix the issue gRPC notify thread blocked #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2020 13:24
…h configurable max buffer size Signed-off-by: Xin Li <[email protected]>
…istener, update test cases Signed-off-by: Xin Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
============================================
+ Coverage 86.81% 86.86% +0.04%
Complexity 210 210
============================================
Files 168 168
Lines 4233 4239 +6
Branches 466 466
============================================
+ Hits 3675 3682 +7
+ Misses 411 409 -2
- Partials 147 148 +1
Continue to review full report at Codecov.
|
…ected by the slow subscriber Signed-off-by: Xin Li <[email protected]>
xin-hedera
commented
Aug 17, 2020
hedera-mirror-grpc/src/test/java/com/hedera/mirror/grpc/listener/AbstractTopicListenerTest.java
Show resolved
Hide resolved
Signed-off-by: Xin Li <[email protected]>
hedera-mirror-grpc/src/main/java/com/hedera/mirror/grpc/controller/ConsensusController.java
Outdated
Show resolved
Hide resolved
...ra-mirror-grpc/src/test/java/com/hedera/mirror/grpc/listener/NotifyingTopicListenerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
steven-sheehy
approved these changes
Aug 19, 2020
Daniel-K-Ivanov
added a commit
to LimeChain/hedera-mirror-node
that referenced
this pull request
Aug 24, 2020
* Fix the issue gRPC notify thread blocked (hiero-ledger#965) Add backpressure buffer with ERROR strategy to notifying and shared polling topic listeners. When overflow happens, the controller will send a gRPC error after all buffered messages and disconnect the client. Signed-off-by: Xin Li <[email protected]> * Performance test HighTPS HCS publish improvements (hiero-ledger#970) * Performance updates to high tps module - Adds additional stats - Allow publish of stats interval to be configured - Does some reorganizing of code - Sets JMeter and java flags to allow for improved publish performance and prevent memory exhaustion Signed-off-by: Nana-EC <[email protected]> * Bump spring-boot-starter-parent from 2.2.7.RELEASE to 2.3.3.RELEASE (hiero-ledger#961) Bumps [spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 2.2.7.RELEASE to 2.3.3.RELEASE. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.2.7.RELEASE...v2.3.3.RELEASE) Signed-off-by: Nana-EC <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xin Li <[email protected]> Co-authored-by: Nana-EC <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Nana-EC
pushed a commit
that referenced
this pull request
Aug 31, 2020
Add backpressure buffer with ERROR strategy to notifying and shared polling topic listeners. When overflow happens, the controller will send a gRPC error after all buffered messages and disconnect the client. Signed-off-by: Xin Li <[email protected]>
Nana-EC
pushed a commit
that referenced
this pull request
Aug 31, 2020
Add backpressure buffer with ERROR strategy to notifying and shared polling topic listeners. When overflow happens, the controller will send a gRPC error after all buffered messages and disconnect the client. Signed-off-by: Xin Li <[email protected]> Signed-off-by: Nana-EC <[email protected]>
xin-hedera
pushed a commit
that referenced
this pull request
Sep 11, 2020
This reverts commit e301647.
xin-hedera
pushed a commit
that referenced
this pull request
Sep 11, 2020
This reverts commit e301647. Signed-off-by: Xin Li <[email protected]>
xin-hedera
added a commit
that referenced
this pull request
Sep 12, 2020
This reverts commit e301647. Signed-off-by: Xin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Add backpressure buffer with ERROR strategy to notifying and shared polling topic listeners. When overflow happens, the controller will send a gRPC error after all buffered messages and disconnect the client.
Which issue(s) this PR fixes:
Fixes #945
Special notes for your reviewer:
Checklist