Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix the issue gRPC notify thread blocked (#965)" #1034

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

xin-hedera
Copy link
Contributor

This reverts commit e301647.

Detailed description:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@xin-hedera xin-hedera force-pushed the revert-grpc-notify-thread-blocked branch from 55f13f3 to 94d3742 Compare September 11, 2020 22:08
@xin-hedera xin-hedera self-assigned this Sep 11, 2020
@xin-hedera xin-hedera requested a review from a team September 11, 2020 22:15
@xin-hedera xin-hedera marked this pull request as ready for review September 11, 2020 22:15
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #1034 into release/0.18 will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.18    #1034      +/-   ##
==================================================
- Coverage           86.58%   86.51%   -0.07%     
  Complexity            211      211              
==================================================
  Files                 176      176              
  Lines                4389     4383       -6     
  Branches              495      495              
==================================================
- Hits                 3800     3792       -8     
- Misses                437      439       +2     
  Partials              152      152              
Impacted Files Coverage Δ Complexity Δ
...ra/mirror/grpc/controller/ConsensusController.java 86.48% <ø> (-0.36%) 13.00 <0.00> (ø)
...edera/mirror/grpc/listener/ListenerProperties.java 91.66% <ø> (-1.20%) 4.00 <0.00> (-1.00)
...a/mirror/grpc/listener/NotifyingTopicListener.java 83.33% <100.00%> (-6.67%) 14.00 <2.00> (ø)
...rror/grpc/listener/SharedPollingTopicListener.java 96.42% <100.00%> (-0.07%) 11.00 <1.00> (ø)
...r/grpc/retriever/PollingTopicMessageRetriever.java 96.15% <0.00%> (-1.93%) 10.00% <0.00%> (ø%)
...irror/importer/parser/record/RecordFileParser.java 89.47% <0.00%> (-1.06%) 0.00% <0.00%> (ø%)
...r/importer/config/MetricsExecutionInterceptor.java 83.82% <0.00%> (+1.47%) 0.00% <0.00%> (ø%)
...a/mirror/grpc/listener/CompositeTopicListener.java 80.00% <0.00%> (+10.00%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556b374...94d3742. Read the comment docs.

@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 performance regression labels Sep 11, 2020
@xin-hedera xin-hedera merged commit 5d51fec into release/0.18 Sep 12, 2020
@xin-hedera xin-hedera deleted the revert-grpc-notify-thread-blocked branch September 12, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 performance regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants