Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use native promise instead of bluebird #295

Merged
merged 2 commits into from
Nov 26, 2022
Merged

refactor: use native promise instead of bluebird #295

merged 2 commits into from
Nov 26, 2022

Conversation

yoshinorin
Copy link
Member

refs: #267

@yoshinorin yoshinorin mentioned this pull request Nov 25, 2022
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 95.533% when pulling bbcb7bf on pr-267 into 2e28b0e on master.

stevenjoezhang
stevenjoezhang approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yoshinorin yoshinorin merged commit 83c85a0 into master Nov 26, 2022
@yoshinorin yoshinorin deleted the pr-267 branch November 26, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshinorin @coveralls @stevenjoezhang @SukkaW