Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use native promise instead of bluebird #267

Closed
wants to merge 1 commit into from
Closed

refactor: use native promise instead of bluebird #267

wants to merge 1 commit into from

Conversation

yoshinorin
Copy link
Member

As is the title.

@stevenjoezhang
Copy link
Member

Hexo itself does not use this spawn function, so we can merge without worrying about performance issues

SukkaW
SukkaW approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that only hexo-deployer-git and hexo init use spawn.

@yoshinorin yoshinorin mentioned this pull request Nov 25, 2022
Merged
@yoshinorin
Copy link
Member Author

yoshinorin commented Nov 25, 2022 •
edited
Loading

@stevenjoezhang @SukkaW
Sorry, I made some mistakes of git operation. I couldn't restore & rebase this branch to master branch. I submit #295 instead of this PR.

Thank you :)

@yoshinorin yoshinorin closed this Nov 25, 2022
@yoshinorin yoshinorin deleted the refactor/use-native-promise-instead-of-bluebird branch November 25, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshinorin @stevenjoezhang @SukkaW