-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Conversation
This is an implementation of Aerospike StatefulSet found here: * https://github.com/aerospike/aerospike-kubernetes
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
… can set more parameters. Now using selector we can use multiple admin built disks that is nearer to a production usage of aerospike
… service needs to be headless so aersopike cluster nodes can find each others by name
…use of internal balancers to expose nodes when cluster is a collection of separate installtions (helm requirements alias)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for the delay. Please update with current master.
version: 0.1.5 | ||
icon: https://s3-us-west-1.amazonaws.com/aerospike-fd/wp-content/uploads/2016/06/Aerospike_square_logo.png | ||
sources: | ||
- https://github.com/aerospike/aerospike-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add maintainers
and appVersion
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks@unguiculus. added maintainers. apiVersion already there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant appVersion
not apiVersion
stable/aerospike/README.md
Outdated
|
||
## Pre Requisites: | ||
|
||
* Kubernetes 1.5 with beta APIs enabled and support for statefulsets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes 1.7+ with beta APIs enabled
``` | ||
|
||
The chart can be customized using the following configurable parameters: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align table nicely.
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: {{ template "fullname" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add standard labels.
replicas: {{ .Values.replicaCount }} | ||
template: | ||
metadata: | ||
labels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only app
and release
labels are usually used here.
items: | ||
- key: aerospike.conf | ||
path: aerospike.conf | ||
volumeClaimTemplates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've started introducing a common pattern for persistence. See #1869. Pleae adapt and use for your PR. Here's a statefulset example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unguiculus thanks and understandable. Just one point. Aerospike needs a set of volumes normally,.Each used for a separate namespace. If I want to follow the suggestion I still need to make it an array and use that array for defining mountVolumes and volumeClaimTemplate.
for example:
stafulset:
{{- if .Values.persistentVolume.enabled }}
volumeClaimTemplates:
{{- range $pv := .Values.persistentVolume.volumes }}
- metadata:
name: {{ $pv.name | quote }}
annotations:
{{- range $key, $value := $pv.annotations }}
{{ $key }}: {{ $value }}
{{- end }}
spec:
accessModes:
{{- range $pv.accessModes }}
- {{ . | quote }}
{{- end }}
resources:
requests:
storage: {{ $pv.size | quote }}
{{- if $pv.storageClass }}
{{- if (eq "-" $pv.storageClass) }}
storageClassName: ""
{{- else }}
storageClassName: "{{ $pv.storageClass }}"
{{- end }}
{{- end }}
selector:
{{ toYaml $pv.selector | indent 8 }}
{{- end }}
{{- else }}
- name: datadir
emptyDir: {}
{{- end }}
values:
persistentVolume:
enabled: true
volumes:
- mountPath: /opt/aerospike/namespace-a-data
name: aerospike-namespace-a-data
storageClass: -
accessModes: [ "ReadWriteOnce" ]
size: "500G"
selector:
matchLabels:
diskname: "aerospike-namespace-a-data"
- mountPath: /opt/aerospike/namespace-b-data
name: aerospike-namespace-b-data
storageClass: -
accessModes: [ "ReadWriteOnce" ]
size: "1500G"
selector:
matchLabels:
diskname: "aerospike-namespace-b-data"
stable/aerospike/values.yaml
Outdated
image: | ||
repository: aerospike/aerospike-server | ||
tag: 3.14.1.2 | ||
pullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use IfNotPresent
as default.
{{/* | ||
Create aerospike mesh setup | ||
*/}} | ||
{{- define "aerospike.mesh" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've started namespacing templates (see #1785). Please apply as well for name
and fullname
.
Marking this as stale. Please update within one week. |
version: 0.1.5 | ||
icon: https://s3-us-west-1.amazonaws.com/aerospike-fd/wp-content/uploads/2016/06/Aerospike_square_logo.png | ||
sources: | ||
- https://github.com/aerospike/aerospike-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant appVersion
not apiVersion
stable/aerospike/Chart.yaml
Outdated
@@ -9,3 +9,6 @@ version: 0.1.5 | |||
icon: https://s3-us-west-1.amazonaws.com/aerospike-fd/wp-content/uploads/2016/06/Aerospike_square_logo.png | |||
sources: | |||
- https://github.com/aerospike/aerospike-server | |||
maintainers: | |||
- name: Kaveh Mousavi Zamani |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Github username
/ok-to-test |
/lgtm |
This is an implementation of Aerospike StatefulSet found here: