Use StorageClassName for PV/PVC in charts

[gyliu513]

Is this a request for help?:

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

In the Kubernetes 1.6 release, dynamic provisioning has been promoted to stable (having entered beta in 1.4). In 1.6, StorageClassName attribute has been added to PersistentVolume and PersistentVolumeClaim objects and should be used instead of annotation volume.beta.kubernetes.io/storage-class.

Version of Helm and Kubernetes:

Which chart:

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

[gyliu513]

/cc @kubernetes/charts-maintainers

[gyliu513]

metadata:
  annotations:
  {{- if .Values.server.persistentVolume.storageClass }}
    volume.beta.kubernetes.io/storage-class: {{ .Values.server.persistentVolume.storageClass | quote }}
  {{- else }}
    volume.alpha.kubernetes.io/storage-class: default
  {{- end }}

Do we need to maintain the alpha and beta here? In the Kubernetes 1.6 release, dynamic provisioning has been promoted to stable (having entered beta in 1.4). In 1.6, StorageClassName attribute has been added to PersistentVolume and PersistentVolumeClaim objects and should be used instead of annotation volume.beta.kubernetes.io/storage-class. The beta annotation is still working in this release, however it will be removed in a future release. Checkout here https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md#volumes-2 for detail.

[unguiculus]

I agree that we should migrate. However, this is not an automatic process. PRs are welcome.

[gyliu513]

@unguiculus why close this one? I may need to reference this if create some PRs.

[unguiculus]

Sorry, I reopened it.

[gyliu513]

@kubernetes/charts-maintainers I'm going to remove volume.alpha.kubernetes.io/storage-class and volume.beta.kubernetes.io/storage-class but use StorageClassName for all charts, please show your comments if any. Thanks.

[unguiculus]

Please make sure you create separate PRs per chart. Thanks.

[gyliu513]

/assign

[unguiculus]

Please use #1332 as reference.

[gyliu513]

Thanks @unguiculus , also mark helm/helm#2600 as related.

[gyliu513]

@prydonius @unguiculus all of the charts are now updated, please help review. Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[gyliu513]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[gyliu513]

/remove-lifecycle rotten

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Activing will cause the issue to no longer be considered stale. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity.