Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jasperreports] Use storageClassName for jasperreports. #1996

Merged
merged 3 commits into from
Dec 22, 2017
Merged

[stable/jasperreports] Use storageClassName for jasperreports. #1996

merged 3 commits into from
Dec 22, 2017

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Sep 5, 2017

Fixed jasperreports for #1869

/cc @prydonius

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2017
@prydonius prydonius self-assigned this Sep 5, 2017
@prydonius
Copy link
Member

@gyliu513 it would make sense to get the same fix in mariadb merged and update the dependency here before merging this

prydonius
prydonius suggested changes Sep 5, 2017
View reviewed changes
Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for mariadb update

@gyliu513
Copy link
Contributor Author

@prydonius The Mariadb patch was now merged #2004

@gyliu513
Copy link
Contributor Author

/cc @prydonius for review

@k8s-ci-robot
Copy link
Contributor

@gyliu513: GitHub didn't allow me to request PR reviews from the following users: for, review.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @prydonius for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@unguiculus
Copy link
Member

/ok-to-test

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, unguiculus

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2017
@k8s-ci-robot k8s-ci-robot merged commit e52e5a5 into helm:master Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@unguiculus unguiculus

@prydonius prydonius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyliu513 @prydonius @k8s-ci-robot @unguiculus