-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Should we still add missing charts OWNERS files? #7446
Comments
i can own some if needed. |
@scottrigby cool, I will try to join the next meeting. the problem it is in the same time as my planning weekly meeting :( |
Before we make owners files we do need to make sure the people are trusted and have contributed. There are numerous people listed as owners who have not contributed before. K8s has a trust system via sponsorships. How do we trust the people we add to owners files? |
Should this list exclude deprecated charts? incubator/drone has been moved to stable and it has its OWNERS file, the incubator chart is there only because of the deprecation process. |
I think this should exclude deprecated charts given we remove the maintainers, @scottrigby do you want to update the list to reflect that? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
incubator/cassandra done :) |
@scottrigby @mattfarina what is the decision here? I'm still willing to take some |
@cpanato The decision here was to add these OWNERS files only as needed (when people request to help maintain them), since our efforts would be better spent moving to the distributed charts hub than opening all of these PRs each with a chart bump (and the coordination with other PRs against those same charts also bumping the version). |
* fixes helm#7446 Signed-off-by: thomasliddledba <[email protected]> * fixes helm#7841 Signed-off-by: thomasliddledba <[email protected]> * Chart version increase and README.md format fix Signed-off-by: thomasliddledba <[email protected]> * added .helmignore Signed-off-by: thomasliddledba <[email protected]> * updated .helmignore Signed-off-by: thomasliddledba <[email protected]>
* fixes helm#7446 Signed-off-by: thomasliddledba <[email protected]> * fixes helm#7841 Signed-off-by: thomasliddledba <[email protected]> * Chart version increase and README.md format fix Signed-off-by: thomasliddledba <[email protected]> * added .helmignore Signed-off-by: thomasliddledba <[email protected]> * updated .helmignore Signed-off-by: thomasliddledba <[email protected]> Signed-off-by: Chaoran Yu <[email protected]>
* fixes helm#7446 Signed-off-by: thomasliddledba <[email protected]> * fixes helm#7841 Signed-off-by: thomasliddledba <[email protected]> * Chart version increase and README.md format fix Signed-off-by: thomasliddledba <[email protected]> * added .helmignore Signed-off-by: thomasliddledba <[email protected]> * updated .helmignore Signed-off-by: thomasliddledba <[email protected]>
Issue to track PRs adding OWNERS files to charts still missing them.
Note I'm not sure if it's worth the extra 148 PRs now that we're working toward the charts distributed search proposal 🤔 Then again, perhaps any little bit towards distributed ownership could be a help in the PR deluge (these ones at least would be quick & easy to review/merge)? Adding this issue for discussion.
find incubator stable -mindepth 1 -maxdepth 1 -type d '!' -exec test -e "{}/OWNERS" ';' -print | sort -u
:The text was updated successfully, but these errors were encountered: