Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Should we still add missing charts OWNERS files? #7446

Closed
scottrigby opened this issue Aug 30, 2018 · 10 comments · Fixed by #9341
Closed

Should we still add missing charts OWNERS files? #7446

scottrigby opened this issue Aug 30, 2018 · 10 comments · Fixed by #9341
Assignees

Comments

@scottrigby
Copy link
Member

scottrigby commented Aug 30, 2018

Issue to track PRs adding OWNERS files to charts still missing them.

Note I'm not sure if it's worth the extra 148 PRs now that we're working toward the charts distributed search proposal 🤔 Then again, perhaps any little bit towards distributed ownership could be a help in the PR deluge (these ones at least would be quick & easy to review/merge)? Adding this issue for discussion.

find incubator stable -mindepth 1 -maxdepth 1 -type d '!' -exec test -e "{}/OWNERS" ';' -print | sort -u:

  • incubator/burrow
  • incubator/cassandra
  • incubator/check-mk
  • incubator/common
  • incubator/couchdb
  • incubator/distribution
  • incubator/drone
  • incubator/etcd
  • incubator/fluentd
  • incubator/fluentd-cloudwatch
  • incubator/gocd
  • incubator/gogs
  • incubator/goldfish
  • incubator/istio
  • incubator/jaeger
  • incubator/keycloak
  • incubator/keycloak-proxy
  • incubator/kube-registry-proxy
  • incubator/kube-spot-termination-notice-handler
  • incubator/kubernetes-vault
  • incubator/kubewatch
  • incubator/mysqlha
  • incubator/oauth-proxy
  • incubator/patroni
  • incubator/puppet-forge
  • incubator/redis-cache
  • incubator/riemann
  • incubator/spring-cloud-data-flow
  • incubator/tensorflow-inception
  • incubator/vault
  • incubator/vaultingkube
  • incubator/webpagetest-agent
  • incubator/webpagetest-server
  • incubator/xray
  • stable/acs-engine-autoscaler
  • stable/aerospike
  • stable/apm-server
  • stable/ark
  • stable/auditbeat
  • stable/aws-cluster-autoscaler
  • stable/bitcoind
  • stable/buildkite
  • stable/centrifugo
  • stable/chronograf
  • stable/cluster-autoscaler
  • stable/consul
  • stable/coscale
  • stable/dask
  • stable/dask-distributed
  • stable/dex
  • stable/distributed-tensorflow
  • stable/efs-provisioner
  • stable/elasticsearch-exporter
  • stable/ethereum
  • stable/express-gateway
  • stable/external-dns
  • stable/factorio
  • stable/filebeat
  • stable/fluent-bit
  • stable/gcloud-endpoints
  • stable/gcp-night-king
  • stable/gitlab-ce
  • stable/gitlab-ee
  • stable/grafana
  • stable/hackmd
  • stable/hadoop
  • stable/heapster
  • stable/heartbeat
  • stable/hlf-ca
  • stable/hlf-couchdb
  • stable/hlf-ord
  • stable/home-assistant
  • stable/hubot
  • stable/influxdb
  • stable/ipfs
  • stable/janusgraph
  • stable/kanister-operator
  • stable/kapacitor
  • stable/katafygio
  • stable/keel
  • stable/keycloak
  • stable/kiam
  • stable/kong
  • stable/kube-lego
  • stable/kube-ops-view
  • stable/kube-slack
  • stable/kube-state-metrics
  • stable/kube2iam
  • stable/kubernetes-dashboard
  • stable/kuberos
  • stable/kured
  • stable/lamp
  • stable/linkerd
  • stable/locust
  • stable/luigi
  • stable/mailhog
  • stable/mcrouter
  • stable/metabase
  • stable/metallb
  • stable/minecraft
  • stable/minio
  • stable/msoms
  • stable/mssql-linux
  • stable/namerd
  • stable/neo4j
  • stable/newrelic-infrastructure
  • stable/nginx-ingress
  • stable/nginx-ldapauth-proxy
  • stable/nginx-lego
  • stable/openebs
  • stable/openldap
  • stable/percona
  • stable/postgresql
  • stable/presto
  • stable/prometheus-adapter
  • stable/prometheus-mysql-exporter
  • stable/prometheus-postgres-exporter
  • stable/prometheus-rabbitmq-exporter
  • stable/prometheus-redis-exporter
  • stable/prometheus-to-sd
  • stable/rabbitmq-ha
  • stable/redis-ha
  • stable/rethinkdb
  • stable/risk-advisor
  • stable/rocketchat
  • stable/rookout
  • stable/sapho
  • stable/selenium
  • stable/sensu
  • stable/sentry
  • stable/signalfx-agent
  • stable/spark
  • stable/spartakus
  • stable/spotify-docker-gc
  • stable/stackdriver-exporter
  • stable/stolon
  • stable/sugarcrm
  • stable/sumokube
  • stable/sumologic-fluentd
  • stable/superset
  • stable/telegraf
  • stable/tomcat
  • stable/uchiwa
  • stable/unbound
  • stable/verdaccio
  • stable/weave-scope
  • stable/zeppelin
  • stable/zetcd
@scottrigby scottrigby self-assigned this Aug 30, 2018
@cpanato
Copy link
Member

cpanato commented Aug 30, 2018

i can own some if needed.

@scottrigby
Copy link
Member Author

@cpanato Awesome, thanks! Let's wait and discuss at the next meeting. I added it to the agenda. We have a large number of PRs now, so we should talk about this in context of the transition priorities.

@cpanato
Copy link
Member

cpanato commented Aug 31, 2018

@scottrigby cool, I will try to join the next meeting. the problem it is in the same time as my planning weekly meeting :(
but count me for any help

@mattfarina
Copy link
Contributor

Before we make owners files we do need to make sure the people are trusted and have contributed. There are numerous people listed as owners who have not contributed before.

K8s has a trust system via sponsorships. How do we trust the people we add to owners files?

@christian-roggia
Copy link
Collaborator

christian-roggia commented Sep 2, 2018

Should this list exclude deprecated charts? incubator/drone has been moved to stable and it has its OWNERS file, the incubator chart is there only because of the deprecation process.

@prydonius
Copy link
Member

I think this should exclude deprecated charts given we remove the maintainers, @scottrigby do you want to update the list to reflect that?

@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2018
@maver1ck
Copy link
Collaborator

incubator/cassandra done :)

@cpanato
Copy link
Member

cpanato commented Oct 17, 2018

@scottrigby @mattfarina what is the decision here? I'm still willing to take some

@scottrigby
Copy link
Member Author

@cpanato The decision here was to add these OWNERS files only as needed (when people request to help maintain them), since our efforts would be better spent moving to the distributed charts hub than opening all of these PRs each with a chart bump (and the coordination with other PRs against those same charts also bumping the version).

davidkarlsen pushed a commit to davidkarlsen/charts that referenced this issue Dec 2, 2018
* fixes helm#7446

Signed-off-by: thomasliddledba <[email protected]>

* fixes helm#7841

Signed-off-by: thomasliddledba <[email protected]>

* Chart version increase and README.md format fix

Signed-off-by: thomasliddledba <[email protected]>

* added .helmignore

Signed-off-by: thomasliddledba <[email protected]>

* updated .helmignore

Signed-off-by: thomasliddledba <[email protected]>
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this issue Dec 11, 2018
* fixes helm#7446

Signed-off-by: thomasliddledba <[email protected]>

* fixes helm#7841

Signed-off-by: thomasliddledba <[email protected]>

* Chart version increase and README.md format fix

Signed-off-by: thomasliddledba <[email protected]>

* added .helmignore

Signed-off-by: thomasliddledba <[email protected]>

* updated .helmignore

Signed-off-by: thomasliddledba <[email protected]>
Signed-off-by: Chaoran Yu <[email protected]>
wgiddens pushed a commit to wgiddens/charts that referenced this issue Jan 18, 2019
* fixes helm#7446

Signed-off-by: thomasliddledba <[email protected]>

* fixes helm#7841

Signed-off-by: thomasliddledba <[email protected]>

* Chart version increase and README.md format fix

Signed-off-by: thomasliddledba <[email protected]>

* added .helmignore

Signed-off-by: thomasliddledba <[email protected]>

* updated .helmignore

Signed-off-by: thomasliddledba <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants