Enable prow merging based on OWNERS files

[mattfarina]

This issue is to track the status of enabling prow so that those in the OWNERS files who are collaborators on the repo can use prow commands to initiate a merge.

cc: @kubernetes/charts-maintainers

[0xmichalis]

You will need to change maintainers to approvers in your OWNERS files I think.

cc: @cjwagner

[mattfarina]

@Kargakis Created a PR for that in #3014

[scottrigby]

Just merged #3014. prow looks excellent BTW!

[mattfarina]

@kubernetes/charts-maintainers We have a detail we need to work out.... do we want to require /lgtm and /approve or just /approve. Any thoughts?

[viglesiasce]

I think just /approve

[mattfarina]

@viglesiasce or just /lgtm? That's an option too.

[scottrigby]

I see that /lgtm adds the label, so that's a functional difference, but is there any semantic difference between the two?

[viglesiasce]

What is the standard if any for other projects? Is there a definition of what /lgtm means vs /approve?

[0xmichalis]

Yeah, there is no such thing as just /approve. You either /lgtm and approval is implicit if you are listed as an approver, or you need to /approve explicitly.

[viglesiasce]

In that case i say just /lgtm

[0xmichalis]

/lgtm is meant to be added by a code reviewer and /approve is meant to be added by a code owner as a high level approval for the change.

[scottrigby]

@Kargakis does /approve add a /lgtm label? I ask because charts README currently specifies this as part of the review process.

[scottrigby]

Ah gotcha 👍 Can anyone run /lgtm command then?

[0xmichalis]

@scottrigby /approve should add an approved label.

[0xmichalis]

/lgtm with implicit approval should also add an approved label.

[0xmichalis]

Anyone with access to the Kubernetes org can /lgtm and add the lgtm label but the approved label is added based on OWNERS files.

[scottrigby]

ok so we should also make sure to update that section of the README. Is there a standard k8s project workflow for these prow commands/labels written up somewhere?

[mattfarina]

See #3008 For an example of using the commands and adding the labels.

I get it enough to do the test-infra config now.

[0xmichalis]

Plugin help is served by prow here.

Plugin help specific to charts is here.

[scottrigby]

PS, I'm loving looking through these self-documenting prow commands 💯

[cblecker]

This is great :)