Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwc2: remove fifo free code. #2575

Merged
merged 1 commit into from
Apr 8, 2024
Merged

dwc2: remove fifo free code. #2575

merged 1 commit into from
Apr 8, 2024

Conversation

HiFiPhile
Copy link
Collaborator

Describe the PR
Follow #2567

hathach
hathach approved these changes Apr 8, 2024
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, better clean these dead code while we still remember :)

@hathach hathach merged commit b90eccc into hathach:master Apr 8, 2024
50 checks passed
@HiFiPhile HiFiPhile deleted the dwc2_free branch April 8, 2024 19:30
@HiFiPhile
Copy link
Collaborator Author

I'm thinking about set configuration request, should FIFO flushed in dcd_edpt_close_all before switching ?

@hathach
Copy link
Owner

hathach commented Apr 10, 2024 •
edited
Loading

I'm thinking about set configuration request, should FIFO flushed in dcd_edpt_close_all before switching ?

Yes, we should flush all tx fifo + rx fifo with close all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiFiPhile @hathach