ISO endpoint allocation improvments #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiFiPhile
commented
Apr 2, 2024
HiFiPhile
commented
Apr 2, 2024
|
Please give me a few days. I would like to check the PR in my environment later. |
|
Take your time :) |
This was referenced Apr 4, 2024
Merged
kkitayam
approved these changes
Apr 6, 2024
|
I had check that the PR works on my RP2040 and RX65N target board. |
|
Thanks for your check, although these 2 mcu don't use fifo allocation feature. I saw allocation is needed in dcd_rp2040 so it would help once it's implemented, not sure the case of RX. |
|
@hathach Maybe my dwc2 PR crashed your HIL test setup... |
Not at all, pi4 seems to struggle with usb stability. I need to do manual reboot after a while. Changes look great, merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
TUP_DCD_EDPT_ISO_ALLOCintotusb_mcu.hvideo_captureandvideo_capture_2chexample work on NUCLEO-G0B1RE with ISO endpoints, previously only bulk endpoints work.Additional context
Now we can remove the buggy buffer free/realloc code from fsdev and dwc2 driver.