auth: store period value on tokens created via login #7885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
commented
Nov 15, 2019
| @@ -2463,57 +2481,8 @@ func testTokenStore_HandleRequest_Lookup(t *testing.T, batch bool) { | |||
| "entity_id": "", | |||
| "type": tokenType, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The diff makes this looks somewhat erroneous, but this deletion is basically to remove the "// Test via POST" step that seems to be happening twice. I suspect that it's a copy/paste duplication.
tyrannosaurus-becks
previously approved these changes
Feb 12, 2020
vishalnayak
approved these changes
Oct 26, 2020
vishalnayak
added a commit
that referenced
this pull request
Oct 26, 2020
* auth: store period value on tokens created via login * test: reduce potentially flaskiness due to ttl check * test: govet on package declaration * changelog++ * Temporarily remove CL entry * Add back the CL entry Co-authored-by: Vishal Nayak <[email protected]>
vishalnayak
added a commit
that referenced
this pull request
Oct 27, 2020
* auth: store period value on tokens created via login * test: reduce potentially flaskiness due to ttl check * test: govet on package declaration * changelog++ * Temporarily remove CL entry * Add back the CL entry Co-authored-by: Vishal Nayak <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodic tokens created directly via the token store as the period value stored as part of its token entry, but the same does not apply for tokens generated via login by auth methods. This PR adds that value to the token entry of tokens generated via login.