Backport: auth: store period value on tokens created via login (#7885) #10244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* auth: store period value on tokens created via login * test: reduce potentially flaskiness due to ttl check * test: govet on package declaration * changelog++ * Temporarily remove CL entry * Add back the CL entry Co-authored-by: Vishal Nayak <[email protected]>
ncabatoff
approved these changes
Oct 27, 2020
|
This PR was lingering from a long time and I think adding CL changes to the PR was being tried out at the time. So I'm bringing in the changes as it was on the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth: store period value on tokens created via login
test: reduce potentially flaskiness due to ttl check
test: govet on package declaration
changelog++
Temporarily remove CL entry
Add back the CL entry
Co-authored-by: Vishal Nayak [email protected]