Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc to 1.22 to address some intermittent ent test failures (attempt2) #7179

Closed
wants to merge 2 commits into from

Conversation

ncabatoff
Copy link
Collaborator

I believe grpc/grpc-go#2818 is the cause of some of our intermittent test failures. The symptoms don't match exactly but they're close, and with this patch applied (along with my other fix) I wasn't able to provoke the "no handler for route" integ test failures. Note that this is apparently a fix for a 1.20 regression.

Process followed:

cd sdk
go get google.golang.org/[email protected]
go mod tidy
git commit
git push
cd ..
go get github.com/hashicorp/vault/sdk@update-grpc-attempt2
go mod tidy
git commit
git push

@jefferai
Copy link
Member

This has the same problem. You're basing the repo SDK update on a commit on this branch but when the branch gets squashed and deleted that commit will no longer be valid.

You need to either do this in two separate PRs, or you need to just not PR it and just do it. :-)

@jefferai jefferai added this to the 1.2 milestone Jul 24, 2019
@ncabatoff
Copy link
Collaborator Author

Now I follow! Ok, I'll just do it on master.

@ncabatoff ncabatoff closed this Jul 24, 2019
@ncabatoff ncabatoff deleted the update-grpc-attempt2 branch July 24, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants