-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest GRPC to make ent integ tests more reliable. #7117
Conversation
I think sdk uses grpc too, in which case the better approach would be to update sdk, then update vault main against new sdk. This should force vault main to use sdk's declared version. |
Done, not sure why api got updated too. |
Could you have another look please @jefferai? |
Please update sdk first with the new version, then have Vault pull in the latest sdk. |
I had already done so. I've pulled in the latest changes from master, then tried doing the above a second time, but it was a no-op. |
You have to update SDK, then push a commit with that up to the repo, then update the main repo against the new SDK. |
Ah, that makes sense, I was just doing |
Looks like you didn't |
First commit in this branch was me doing it wrong, i.e.
Second commit was merge of master. Third commit was result of
Since I'm now confused and wanted a fresh start I created a new branch and will close this PR and work with that one instead (#7179). |
I believe grpc/grpc-go#2818 is the cause of some of our intermittent test failures. The symptoms don't match exactly but they're close, and with this patch applied (along with my other fix) I wasn't able to provoke the "no handler for route" integ test failures. Note that this is apparently a fix for a 1.20 regression.